[TAPESTRY-1709] Radio component throws an exception when used with RadioGroup and Label

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.5
• Fix Version/s: 5.0.6
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Nick Westgate
• Created: 16/Aug/07 07:47
• Updated: 29/Sep/07 15:55
• Resolved: 29/Sep/07 15:55

Description

Example code that breaks:
<t:RadioGroup t:id="group1">
<t:Radio t:id="radio1" t:value="value1"/><t:Label for="radio1"/>
</t:RadioGroup>

Exception is:
No object of type org.apache.tapestry.RadioContainer is available from the Environment.

The reason is that the Label validation rendering calls Radio.getElementName() after the RadioGroup has been popped from the environment.
A simple fix is to cache the element name:

private String _elementName;
...
public String getElementName()

{ return _elementName; }

...
void beginRender(MarkupWriter writer)

{ ... _elementName = _container.getElementName(); writer.element("input", "type", "radio", "id", _clientId, "name", _elementName, "value", value); ... }

Cheers,
Nick.