Tapestry
  1. Tapestry
  2. TAPESTRY-1699

Dialog component crashing on its most simple use (hidden parameter default value)

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 4.1.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Well this is a replacement for TAPESTRY-1682 that was opened due to my total misunderstanding of binding mechanism on default-value for parameters (sorry for that).

      In fact the problem that lead me to that is that Dialog component as it is, used in its simplest form (opening and closing a dialog popup) will fail without overriding default binding for hidden parameter as calling hide()/show() methods will try to write on a invariant binding (the default "true" constant). I think this is a bug as default behaviour for a component should be to work as expected and default values shouldn't get in the way.

      My proposal is then to remove defaul binding from parameter so to have it unbounded by default

      <parameter name="hidden"/>

      and add "direct" initialization of the parameter by default

      public void finishLoad() {
      super.finishLoad();
      if (!isParameterBound("hidden"))

      { setHidden(true); }

      }

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Martino Piccinato
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development