Tapestry
  1. Tapestry
  2. TAPESTRY-1336

Refactor ApplicationGlobals's store methods

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.0.3
    • Fix Version/s: 5.0.11
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      there is three "store" methods (with diffrent parameter type) in ApplicationGlobals

      void store(ServletContext context);
      void store(Context context);
      void store(String applicationRootPackage);

      if we need another "store" method with a String parameter in the future, what to do with it? store(String) is already there!

      so rename these methods to storeServletContext(), storeContext(), storeApplicationRootPackage() maybe ok, and clear its meaning.

      Sorry for poor english!

        Activity

        liigo created issue -
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 5.0.11 [ 12312968 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12399171 ] Default workflow, editable Closed status [ 12569196 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12569196 ] jira [ 12592123 ]

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            liigo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development