Tapestry
  1. Tapestry
  2. TAPESTRY-873 Minor XHTML 1.0 Strict compliance issues
  3. TAPESTRY-1231

org.apache.tapestry.form.ImageSubmit renders invalid XHTML attribute 'border="0"'

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.2, 4.1.1
    • Fix Version/s: 4.1.2
    • Component/s: Framework
    • Labels:
      None

      Description

      ImageSubmit components renders invalid XHTML attribute 'border="0"' for <input type="image" ...

      Index: ImageSubmit.java
      ===================================================================
      — ImageSubmit.java (revision 496491)
      +++ ImageSubmit.java (working copy)
      @@ -69,9 +69,10 @@

      // NN4 places a border unless you tell it otherwise.
      // IE ignores the border attribute and never shows a border.
      +
      + // 'border' is not XHTML compliant
      + // writer.attribute("border", 0);

      • writer.attribute("border", 0);
        -
        writer.attribute("src", imageURL);

      renderIdAttribute(writer, cycle);

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        17d 15h 21m 1 Andreas Andreou 02/Feb/07 12:47
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12569231 ] jira [ 12592134 ]
        Mark Thomas made changes -
        Workflow jira [ 12394338 ] Default workflow, editable Closed status [ 12569231 ]
        Andreas Andreou made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Andreas Andreou added a comment -

        thx for noticing

        Show
        Andreas Andreou added a comment - thx for noticing
        Andreas Andreou made changes -
        Assignee Andreas Andreou [ andyhot ]
        Jesse Kuhnert made changes -
        Field Original Value New Value
        Fix Version/s 4.1.2 [ 12312202 ]
        David Davis created issue -

          People

          • Assignee:
            Andreas Andreou
            Reporter:
            David Davis
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development