[TAP5-986] A request can fail with an NPE in some cases, when a Tapestry page is acting as the servlet container error page

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0.5
• Fix Version/s: 5.3.6, 5.4
• Component/s: tapestry-core
• Assignee: Kalle Korhonen
• Reporter: Christophe Cordenier
• Created: 14/Jan/10 14:40
• Updated: 05/Oct/12 00:38
• Resolved: 03/Oct/12 05:08

Description

With this kind of configuration in web.xml :

<filter-mapping>
<filter-name>tapestryFilter</filter-name>
<url-pattern>/*</url-pattern>
<dispatcher>ERROR</dispatcher>
<dispatcher>REQUEST</dispatcher>
</filter-mapping>
<error-page>
<error-code>403</error-code>
<location>/error/AccessDenied</location>
</error-page>
<error-page>
<error-code>404</error-code>
<location>/error/NotFound</location>
</error-page>

RestoreDirtySessionObjects is generating a NullPointerException with this line :

Session session = request.getSession(false);

It seems that the dispatching is done in one single thread, then the initial class to RestoreDirtySessionObjects is delay, and request object is lost.

Issue Links

• is duplicated by: TAP5-1017 npe thrown when using custom 404 page