Tapestry 5
  1. Tapestry 5
  2. TAP5-937

LinkImpl does not handle parameters properly when passed into the constructor

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      I noticed this after using the AjaxFormLoop AddRowLink on a page which has an onActivate and onPassivate resulting in the addition of a "t:ac" to the url. Debugging showed me that the t:ac is already present on instantiation of the LinkImpl. When calling toAbsoluteUri the parameters are added in a way where they will always start with a "?". Obvisouly resulting in an invalid URL with two ?'s

      I'm building a failing test at this stage and will provide a patch once resolved.

        Activity

        Joost Schouten created issue -
        Joost Schouten made changes -
        Field Original Value New Value
        Attachment parameter_addition_patch.txt [ 12426334 ]
        Joost Schouten made changes -
        Attachment parameter_addition_patch.txt [ 12426334 ]
        Joost Schouten made changes -
        Attachment parameter_addition_patch.txt [ 12427314 ]
        Igor Drobiazko made changes -
        Summary LinkImpl does not handle parameters propery when passed into the constructor LinkImpl does not handle parameters properly when passed into the constructor
        Igor Drobiazko made changes -
        Assignee Igor Drobiazko [ igor.drobiazko ]
        Igor Drobiazko made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.2.0 [ 12314122 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Igor Drobiazko
            Reporter:
            Joost Schouten
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development