[TAP5-804] Element#addClassName can create an additional new 'class' attribute

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.18
• Fix Version/s: 5.2.2
• Component/s: tapestry-core
• Assignee: Josh Canfield
• Reporter: Paul Field
• Created: 05/Aug/09 12:54
• Updated: 19/Oct/10 19:45
• Resolved: 17/Oct/10 22:22

Description

When writing a mixin that uses Element#addClassName, I noticed that I was getting two 'class' attributes in my element - rather than the one I was expecting.

I've narrowed the problem down to a problem with how namespaces are used in Element and the following test case shows the problem. The "actual" output is:

<e class="a b" class="a" xmlns="http://www.w3.org/1999/xhtml"></e>

--------------------------------------

package test.com.db.fusion.iface.web.tapestry5.mixins;

import junit.framework.TestCase;

import org.apache.tapestry5.dom.DefaultMarkupModel;
import org.apache.tapestry5.dom.Document;
import org.apache.tapestry5.dom.Element;

public class AddClassNameTest extends TestCase {

public void test()

{ Document document = new Document(new DefaultMarkupModel()); Element element = document.newRootElement("http://www.w3.org/1999/xhtml", "e"); element.attribute("class", "a"); element.addClassName("b"); assertEquals("<e class=\"a b\" xmlns=\"http://www.w3.org/1999/xhtml\"></e>", element.toString()); }

}

Issue Links

• relates to: TAP5-708 Element.forceAttribute uses the element's namespace to match the attribute.