[TAP5-646] When Tapestry is combining JavaScript files, it should check for a JS file that ends with an unterminated comment, and add the comment terminator

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.0.4
• Fix Version/s: 5.1.0.4
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Howard Lewis Ship
• Created: 15/Apr/09 14:57
• Updated: 21/Apr/09 21:12
• Resolved: 21/Apr/09 21:12

Description

From the mailing list:

I'm found were is the problem...

It's appear only when tapestry.production-mode=true.
As I'm understand in this mode all JavaScripts gather in one virtual .js.
But one of my script have comment at the last line!!!!!
The next script added to the end of previous one without CL, so the meaning
line of the second script became commented...
I'm solve the problem, but IMHO it's need to change virtual file gathering
in order to prevent such a situation.

To be honest, this one goes to user error, but the unterminated comment doesn't cause problems with many individual <script> tags, just with the virtual combined script, so I guess it falls in Tapestry's lap.