Tapestry 5
  1. Tapestry 5
  2. TAP5-406

Remove IDEA and Eclipse control files from the source tree

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.1
    • Fix Version/s: 5.1.0.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      just a very small patch to turn off invalid errors from eclipse..

      1. less-errors.diff
        3 kB
        Fernando Padilla

        Activity

        Hide
        Andreas Andreou added a comment -

        Why not fix those the other way around, i.e. by adding @Override where it's missing, or removing the unnecessary casts, e.t.c.

        Unless you're saying that eclipse reports false positives.

        Show
        Andreas Andreou added a comment - Why not fix those the other way around, i.e. by adding @Override where it's missing, or removing the unnecessary casts, e.t.c. Unless you're saying that eclipse reports false positives.
        Hide
        Fernando Padilla added a comment -

        a long time ago Howard put turned up the warnings on eclipse to be errors. But since then, Howard has moved off of eclipse, and noone is maintaining the code. So without turning down these warnings, eclipse has lots of "errors".

        And truly, these are not real errors, simply us being anal. When we don't have to be. Unless Howard can turn on the same "errors" on IntelliJ and be able to actively maintain them, they should be turned off. period. no use in maintaining different code standards for those using eclipse, versus Howard using IntelliJ.

        Show
        Fernando Padilla added a comment - a long time ago Howard put turned up the warnings on eclipse to be errors. But since then, Howard has moved off of eclipse, and noone is maintaining the code. So without turning down these warnings, eclipse has lots of "errors". And truly, these are not real errors, simply us being anal. When we don't have to be. Unless Howard can turn on the same "errors" on IntelliJ and be able to actively maintain them, they should be turned off. period. no use in maintaining different code standards for those using eclipse, versus Howard using IntelliJ.
        Hide
        Andreas Andreou added a comment -

        Actually, i'd vote for removing ide specific files - there's the pom and at least 3 ways to work from that in each major IDE.

        Also, I use idea and even howard's idea specific files are a bit annoying (=marked as dirty by svn)

        Show
        Andreas Andreou added a comment - Actually, i'd vote for removing ide specific files - there's the pom and at least 3 ways to work from that in each major IDE. Also, I use idea and even howard's idea specific files are a bit annoying (=marked as dirty by svn)
        Hide
        Fernando Padilla added a comment -

        well, for now, how about someone commit this little tiny inzy binzy patch file, to make us eclipse users happy. we can discuss the bigger ideas later

        though I might see you point, I like that projects have predefined eclipse files, for various reasons.. no need to manually keep the classpath in sync is one, and making sure that all users have the same formatter, etc etc..

        in the .settings files we don't have to setup the compiler warnings at all, and just leave them as default too.. but we use it in our company to setup the default formatter, which is key to make sure we're all formatting the code the same way.

        Show
        Fernando Padilla added a comment - well, for now, how about someone commit this little tiny inzy binzy patch file, to make us eclipse users happy. we can discuss the bigger ideas later though I might see you point, I like that projects have predefined eclipse files, for various reasons.. no need to manually keep the classpath in sync is one, and making sure that all users have the same formatter, etc etc.. in the .settings files we don't have to setup the compiler warnings at all, and just leave them as default too.. but we use it in our company to setup the default formatter, which is key to make sure we're all formatting the code the same way.
        Hide
        Howard M. Lewis Ship added a comment -

        I think Andreas is right about IDE specific files, though I'm not sure why they get marked as dirty for others; I thought I only checked in the ones that should be the same across users and workspaces (i.e., no absolute file names). I may be wrong, because it looks like IDEA plugs can get in and change the files as well, so unless all developers are using the exact same set of plugins, some of the files may be corrupted.

        Show
        Howard M. Lewis Ship added a comment - I think Andreas is right about IDE specific files, though I'm not sure why they get marked as dirty for others; I thought I only checked in the ones that should be the same across users and workspaces (i.e., no absolute file names). I may be wrong, because it looks like IDEA plugs can get in and change the files as well, so unless all developers are using the exact same set of plugins, some of the files may be corrupted.
        Hide
        Andreas Andreou added a comment -

        Howard, for the record, i prefer opening projects from the pom.xml - it basically allows
        me to open only a specific subproject i want to work on, e.t.c.

        This however overwrites the subproject's *.iml file and that's why it's locally dirty.

        Show
        Andreas Andreou added a comment - Howard, for the record, i prefer opening projects from the pom.xml - it basically allows me to open only a specific subproject i want to work on, e.t.c. This however overwrites the subproject's *.iml file and that's why it's locally dirty.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Fernando Padilla
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development