[TAP5-2705] Fix warning Could not add object with duplicate id 'tapestry.css'

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.5.0, 5.6.0, 5.6.1, 5.6.2, 5.7.0, 5.6.3, 5.7.1, 5.7.2, 5.6.4, 5.7.3, 5.8.0
• Fix Version/s: 5.8.1
• Component/s: tapestry-core
• Labels: bootstrap core stylesheet warn
• Assignee: Thiago Henrique De Paula Figueiredo
• Reporter: D Tim Cummings
• Created: 13/Feb/22 00:59
• Updated: 06/Mar/22 20:35
• Resolved: 06/Mar/22 19:48

Description

For the last few versions of tapestry, the following warning messages would show in the logs

WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tapestry.css'.  The duplicate object has been ignored.
WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'exception-frame.css'.  The duplicate object has been ignored.
WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tapestry-console.css'.  The duplicate object has been ignored.
WARN  org.apache.tapestry5.modules.JavaScriptModule.CoreJavaScriptStack Could not add object with duplicate id 'tree.css'.  The duplicate object has been ignored.

I think this is because the method addCoreStylesheets in JavaScriptModule is being called multiple times but it should only be called once. This is mainly related to adding bootstrap 4 and font-awesome. I have created a diff which shows what changes are needed so that addCoreStylesheets is only called once. Unfortunately I haven't been able to test it as I haven't worked out yet how to build tapestry from source.