[TAP5-2669] Tapestry Form.js running on non Tapestry forms

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.7.2, 5.6.4
• Assignee: Thiago Henrique De Paula Figueiredo
• Reporter: Alex Craddock
• Created: 31/Mar/21 15:34
• Updated: 06/Apr/21 22:46
• Resolved: 05/Apr/21 20:43

Description

There is an issue when a non Tapestry form is being submitted, the Javascript in Form.js is triggered, specifically, 

 

dom.onDocument("click", "input[type=submit], input[type=image]", function() { setSubmittingHidden(dom(this.element.form), this); });

 

This is then causing a t:submit parameter to be added to the request query parameters via, 

 

setSubmittingHidden

 hidden = form.findFirst("[name='t:submit']");
      if (!hidden) {
        firstHidden = form.findFirst("input[type=hidden]");
        hidden = dom.create("input", {
          type: "hidden",
          name: "t:submit"
        });
        firstHidden.insertBefore(hidden);
      }
      name = isCancel ? "cancel" : submitter.element.name;
      hidden.value("[\"" + submitter.element.id + "\",\"" + name + "\"]");