Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-266

In a conflict between a render phase annotation and the naming convention, the explicit annotation should win

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 5.0.15
    • 5.2.0
    • tapestry-core
    • None

    Description

      If i have a method like this:

      @AfterRender
      void beginRender()
      {
      }

      it actually gets executed twice. Once during AfterRender and once during BeginRender. Although i agree that is bad coding it can cause some confusion and make it hard to diagnose.

      In my opinion there should be either an error thrown by Tapestry in this situation or it should just ignore the method name when a render phase annotation is present.

      Also, i didn't try if this also happens for component events.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hlship Howard Lewis Ship
            hpalma Hugo Palma
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment