[TAP5-2511] Named AMD modules cannot be added to JavaScript stack

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 5.4
• Component/s: tapestry-core
• Assignee: Unassigned
• Reporter: Jochen Kemnade
• Created: 20/Oct/15 13:27
• Updated: 20/Oct/15 15:43

Description

The define statement rewriting logic in org.apache.tapestry5.internal.services.assets.JavaScriptStackAssemblerImpl.ModuleReader breaks stacks with named modules. For example, jquery 3.0-alpha1 (https://cdnjs.cloudflare.com/ajax/libs/jquery/3.0.0-alpha1/jquery.js) uses

define( "jquery", [], function() {
		return jQuery;
	});

The ModuleReader turns that into

define("jquery", "jquery", [], function() {
		return jQuery;
	});

which will not work. We should probably not rewrite named define calls.