[TAP5-2487] t:extension-point declaration in tapestry_*.xsd's have never been correct

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3, 5.4, 5.2, 5.1
• Fix Version/s: 5.4
• Labels: 54_release_prerequisite
• Assignee: Jochen Kemnade
• Reporter: Chris Poulsen
• Created: 10/Aug/15 09:20
• Updated: 20/Oct/15 14:50
• Resolved: 20/Oct/15 14:18

Description

JetBrains has just improved their tapestry plugin to use the specfied tapestry_x_x.xsd when indicating errors in .tml files.

<t:extension-point id="<id>"> is flagged with a missing required attribute name (according to the xsd), however the ExtensionPointToken / SaxTemplateParser seems to expect an attribute called "id" being specified, using "name" results in a tapestry exception:

...
Caused by: org.apache.tapestry5.ioc.internal.util.TapestryException: Element <extension-point> does not support an attribute named 'name'. The only allowed attribute name is 'id'.

I guess the easiest fix is to alter the xsd's to match the actual parser code to prevent breaking existing tapestry applications.

This is a trivial fix and could be a nice thing to have in place before releasing 5.4