[TAP5-2475] Form Field in Loop : on validation error all field get the same value

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Cannot Reproduce
• Affects Version/s: 5.4
• Fix Version/s: 5.4
• Component/s: tapestry-core
• Labels: form validation
• Assignee: Unassigned
• Reporter: Nicolas Bouillon
• Created: 29/Apr/15 10:55
• Updated: 30/Apr/15 10:19
• Resolved: 30/Apr/15 10:15

Description

On 5.4-beta-26.

Given a template like this :

<t:form t:id="form">
        <t:errors/>
        <t:loop source="items" value="item">
            <div>
                <t:label for="field"/>
                <t:textfield t:id="field" value="value" label="prop:item"/>
            </div>
        </t:loop>
        <div>
            <t:submit/>
        </div>
    </t:form>

If the validation of the form fails (global validation), the page is displayed with all the field containing the same value, the last one.

Index.java

public class Index {

    private Map<String, String> values;

    @Property
    private String item;

    public String[] getItems() {
        return new String[]{"one", "two", "three"};
    }

    public void setValue(String value) {
        if (values == null) {
            values = new LinkedHashMap<>();
        }
        values.put(item, value);
    }

    public String getValue() {
        if (values == null) {
            values = new LinkedHashMap<>();
            for (String item : getItems()) {
                values.put(item, item);
            }
        }
        return values.get(item);
    }

    @Inject
    private AlertManager alertManager;

    @InjectComponent
    private Form form;

    public void onValidateFromForm() {
        form.recordError("Purposely generated error");
    }

    public void onSuccessFromForm() {
        for (Map.Entry<String, String> entry : values.entrySet()) {
            alertManager.info(entry.getKey() + " = " + entry.getValue());
        }
    }
}

Any help will be welcomed to guide me to provide a patch.

Issue Links

• duplicates: TAP5-2391 Field-specific error not shown when AJAX used