Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2471

DefaultRequestExceptionHandler creating absolute links for xhr request

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.4
    • 5.4
    • None
    • None

    Description

      I'm using relative links throughout my application and allowing our reverse proxy to handle our secure port forwarding.

      I just discovered that DefaultRequestExceptionHandler on line 210 is creating an absolute link for all xhr request.

      https://github.com/apache/tapestry-5/blob/840533975a33d9094789bc09e40557a5c3ec7ba8/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DefaultRequestExceptionHandler.java

      It has suggested on the mailing list by Dimitris Zenios to be link.toRedirectURI instead of toAbsoluteURI just like
      AjaxLinkComponentEventResultProcessor does.

      http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/DefaultRequestExceptionHandler-not-redirect-xhr-request-to-a-secure-link-td5730392.html

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hlship Howard Lewis Ship
            gchristman George Christman
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment