[TAP5-2160] Button type submit should be ignored in ajax form submission just like input type submit

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 5.3.7
• Fix Version/s: 5.4
• Component/s: tapestry-core
• Labels: ajax button forms javascript
• Assignee: Unassigned
• Reporter: Raul Montes
• Created: 26/Aug/13 17:15
• Updated: 19/Aug/15 13:40
• Resolved: 19/Aug/15 13:40

Description

In tapestry.js, line 808, inputs type submit are ignored for form serialization (in case of ajax form submission). But button type submit are also a valid way of submitting the form. Besides, as with input type submit, it doesn't make sense to send buttons as fields values.

Prototype 1.6 automatically ignored button elements when serializing, but 1.7 includes them. In order to avoid sending this data pointlessly, line 808 could be changed to:

return (e.tagName == "INPUT" || e.tagName == "BUTTON") && e.type == "submit";