Tapestry 5
  1. Tapestry 5
  2. TAP5-216

Many methods of the Page interface could be moved to PageResources (which should be renamed to ComponentPageElementResources)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.0
    • Fix Version/s: 5.1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Just an observation; many methods on Page were done to cut down on the number of injections passed to each ComponentPageElementImpl ... however, since then the PageResources interface was introduced to act as a facade over services needed by the ComponenPageElementImpl.

      I think several methods of Page could be moved to PageResources, which would simplify PageImpl and the (increasing number of) dependencies passed to it.

      Also, PageResourcs could be renamed ComponentPageElementResources, and a new PageResources facaded could be introduced for PageImpl.

        Activity

        Howard M. Lewis Ship created issue -
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.1.0.0 [ 12313419 ]
        Assignee Howard M. Lewis Ship [ hlship ]
        Fix Version/s 5.1 [ 12312964 ]
        Resolution Fixed [ 1 ]
        Howard M. Lewis Ship made changes -
        Project Tapestry [ 10573 ] Tapestry 5 [ 12310833 ]
        Key TAPESTRY-2665 TAP5-216
        Affects Version/s 5.1.0.0 [ 12313428 ]
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Fix Version/s 5.1.0.0 [ 12313419 ]
        Affects Version/s 5.0.14 [ 12313214 ]
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.1.0.0 [ 12313428 ]
        Howard M. Lewis Ship made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        4d 22h 3m 1 Howard M. Lewis Ship 17/Sep/08 16:25

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development