Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2068

Use <button>, not <a>, tags for the close buttons on alerts

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 5.4
    • 5.4
    • tapestry-core
    • None

    Description

      Add type="button" to button used to close alerts so the enter key continues to submit the form if the alerts block is inside a form.

      I don't know much about coffeescript but the javascript changes below makes it work for me.

      From:
      element = builder("div",

      { "class": className }

      , ["button.close", "\u00d7"], content);

      To:
      element = builder("div",

      { "class": className }

      , ["button.close",

      { "type":"button" }

      , "\u00d7"], content);

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hlship Howard Lewis Ship
            dustinywoods Dustin Woods
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment