Tapestry 5
  1. Tapestry 5
  2. TAP5-1996

Add Severity.SUCCESS enum for alerts

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.5
    • Fix Version/s: 5.3.6, 5.4
    • Component/s: tapestry-core
    • Labels:

      Description

      I'm currently implementing twitter-bootstrap integration for alerts and found that tapestry5 lacks this value.

      http://twitter.github.com/bootstrap/components.html#alerts

      1. TAP5-1996.patch
        5 kB
        Dmitry Gusev
      2. new-alerts-look-and-feel.jpg
        11 kB
        Dmitry Gusev

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #962 (See https://builds.apache.org/job/tapestry-trunk-freestyle/962/)
        FIXED - TAP5-1996: Add Severity.SUCCESS enum for alerts (Revision aa3ee48cf946159f165cb0a3b7ccf6a0641417cf)

        Result = FAILURE
        kaosko :
        Files :

        • tapestry-core/src/main/java/org/apache/tapestry5/alerts/Severity.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #962 (See https://builds.apache.org/job/tapestry-trunk-freestyle/962/ ) FIXED - TAP5-1996 : Add Severity.SUCCESS enum for alerts (Revision aa3ee48cf946159f165cb0a3b7ccf6a0641417cf) Result = FAILURE kaosko : Files : tapestry-core/src/main/java/org/apache/tapestry5/alerts/Severity.java
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #951 (See https://builds.apache.org/job/tapestry-trunk-freestyle/951/)
        FIXED - TAP5-1996: Add Severity.SUCCESS enum for alerts (Revision aea07df75c1149b3a0ca0cc864d949f39d550c93)

        Result = FAILURE
        kaosko :
        Files :

        • tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #951 (See https://builds.apache.org/job/tapestry-trunk-freestyle/951/ ) FIXED - TAP5-1996 : Add Severity.SUCCESS enum for alerts (Revision aea07df75c1149b3a0ca0cc864d949f39d550c93) Result = FAILURE kaosko : Files : tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
        Hide
        Dmitry Gusev added a comment -

        Thank you very much, Kalle!

        Show
        Dmitry Gusev added a comment - Thank you very much, Kalle!
        Hide
        Kalle Korhonen added a comment -

        I cherry-picked this to 5.3 branch as well but unfortunately with the original commit message. In 5.4 I fixed the commit message but already pushed the changes without modifying the 5.3 branch, so it only shows up with the correct JIRA id in the master.

        Show
        Kalle Korhonen added a comment - I cherry-picked this to 5.3 branch as well but unfortunately with the original commit message. In 5.4 I fixed the commit message but already pushed the changes without modifying the 5.3 branch, so it only shows up with the correct JIRA id in the master.
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #929 (See https://builds.apache.org/job/tapestry-trunk-freestyle/929/)
        TAP5-1996: Add Severity.SUCCESS enum for alerts (Revision 17a9f42e7651e3f15fc2e62da95eac36cc004844)

        Result = FAILURE
        kaosko :
        Files :

        • tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java
        • tapestry-core/src/main/java/org/apache/tapestry5/alerts/Severity.java
        • tapestry-core/src/main/resources/org/apache/tapestry5/t5-alerts.css
        • tapestry-core/src/main/resources/org/apache/tapestry5/silk/accept.png
        • tapestry-core/src/main/java/org/apache/tapestry5/internal/alerts/AlertManagerImpl.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #929 (See https://builds.apache.org/job/tapestry-trunk-freestyle/929/ ) TAP5-1996 : Add Severity.SUCCESS enum for alerts (Revision 17a9f42e7651e3f15fc2e62da95eac36cc004844) Result = FAILURE kaosko : Files : tapestry-core/src/main/java/org/apache/tapestry5/alerts/AlertManager.java tapestry-core/src/main/java/org/apache/tapestry5/alerts/Severity.java tapestry-core/src/main/resources/org/apache/tapestry5/t5-alerts.css tapestry-core/src/main/resources/org/apache/tapestry5/silk/accept.png tapestry-core/src/main/java/org/apache/tapestry5/internal/alerts/AlertManagerImpl.java
        Hide
        Dmitry Gusev added a comment -

        Background-color for INFO level changed to #08f (light blue)
        SUCCESS level have now color 'green' (which was previously used for INFO) and icon 'accept.png' from the famfamfam silk icons.

        Show
        Dmitry Gusev added a comment - Background-color for INFO level changed to #08f (light blue) SUCCESS level have now color 'green' (which was previously used for INFO) and icon 'accept.png' from the famfamfam silk icons.
        Hide
        Dmitry Gusev added a comment -

        Add support for Severity.SUCCESS

        Show
        Dmitry Gusev added a comment - Add support for Severity.SUCCESS

          People

          • Assignee:
            Kalle Korhonen
            Reporter:
            Dmitry Gusev
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development