[TAP5-1979] Changing the implementation of a method after adding method advice does not work; the original implementation remains

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3, 5.4
• Fix Version/s: 5.3.5, 5.4
• Component/s: plastic
• Labels: fixed-in-5.4-js-rewrite
• Assignee: Howard Lewis Ship
• Reporter: Howard Lewis Ship
• Created: 24/Jul/12 21:31
• Updated: 16/Dec/12 01:45
• Resolved: 16/Dec/12 01:30

Description

This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes.

Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten.

The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed.

Issue Links

• is related to: TAP5-1752 Component cannot receive any event in a case when transformer added event handler before OnEventWorker
• relates to: TAP5-1601 Sometime a method that references a field with a conduit will not be instrumented, resulting in an NPE accessing the field itself