Tapestry 5
  1. Tapestry 5
  2. TAP5-1979

Changing the implementation of a method after adding method advice does not work; the original implementation remains

    Details

      Description

      This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes.

      Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten.

      The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed.

        Issue Links

          Activity

          Howard M. Lewis Ship created issue -
          Howard M. Lewis Ship made changes -
          Field Original Value New Value
          Link This issue relates to TAP5-1601 [ TAP5-1601 ]
          Howard M. Lewis Ship made changes -
          Assignee Howard M. Lewis Ship [ hlship ]
          Howard M. Lewis Ship made changes -
          Summary Plastic should throw an exception when a method implementation is rewritten AFTER method advice is added Changing the implementation of a method after adding method advice does not work; the original implementation remains
          Description This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes.

          Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten.
          This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes.

          Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten.

          The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed.
          Howard M. Lewis Ship made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Fix Version/s 5.3.5 [ 12322440 ]
          Resolution Fixed [ 1 ]
          Howard M. Lewis Ship made changes -
          Link This issue is related to TAP5-1752 [ TAP5-1752 ]
          Howard M. Lewis Ship made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Howard M. Lewis Ship made changes -
          Labels fixed-in-5.4-js-rewrite
          Howard M. Lewis Ship made changes -
          Fix Version/s 5.3.6 [ 12322961 ]
          Fix Version/s 5.3.5 [ 12322440 ]
          Howard M. Lewis Ship made changes -
          Fix Version/s 5.3.5 [ 12322440 ]
          Fix Version/s 5.3.6 [ 12322961 ]
          Howard M. Lewis Ship made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Fix Version/s 5.4 [ 12316401 ]

            People

            • Assignee:
              Howard M. Lewis Ship
              Reporter:
              Howard M. Lewis Ship
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development