Tapestry 5
  1. Tapestry 5
  2. TAP5-1976

XML Parser adds attributes with default values and produces invalid HTML5 markup

    Details

      Description

      After some research I found out that this issue is a reoccurring one - which never really has been fixed.
      The first one was TAP5-171 the second TAP5-1044
      The problem hasn't changed very much except that deleting the doctype doesn't help anymore since t5.3 as xhtml transitional is used in memory when none is provided (same for the html5 doctype) (source: http://tapestry.apache.org/component-templates.html#ComponentTemplates-TemplateDoctypes).
      When using html5 the problem is that invalid html markup is generated, for example:

      • a br tag renders as <br clear="none"/> where clear is invalid html5
      • an a tag renders as <a shape="rect">... where the shape attribute is invalid html5

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        32d 10h 32m 1 Howard M. Lewis Ship 17/Aug/12 22:48
        In Progress In Progress Closed Closed
        120d 2h 41m 1 Howard M. Lewis Ship 16/Dec/12 01:30
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #977 (See https://builds.apache.org/job/tapestry-trunk-freestyle/977/)
        TAP5-1976: XML Parser adds attributes with default values and produces invalid HTML5 markup (Revision d25c142345e03869f71ab7f4133734cc8eb2ee13)

        Result = FAILURE
        hlship :
        Files :

        • tapestry-core/src/test/java/org/apache/tapestry5/internal/services/TemplateParserImplTest.java
        • tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java
        • tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/default_attributes_not_included.tml
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #977 (See https://builds.apache.org/job/tapestry-trunk-freestyle/977/ ) TAP5-1976 : XML Parser adds attributes with default values and produces invalid HTML5 markup (Revision d25c142345e03869f71ab7f4133734cc8eb2ee13) Result = FAILURE hlship : Files : tapestry-core/src/test/java/org/apache/tapestry5/internal/services/TemplateParserImplTest.java tapestry-core/src/main/java/org/apache/tapestry5/internal/services/XMLTokenStream.java tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/default_attributes_not_included.tml
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 5.4 [ 12316401 ]
        Hide
        Howard M. Lewis Ship added a comment -

        It is unfortunate that having Xerces (at least, the old 2.4.0 version that's in one of my client projects) provides a SAXParser that uses the old Attributes interface and not the Attributes2 interface.

        Show
        Howard M. Lewis Ship added a comment - It is unfortunate that having Xerces (at least, the old 2.4.0 version that's in one of my client projects) provides a SAXParser that uses the old Attributes interface and not the Attributes2 interface.
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.3.5 [ 12322440 ]
        Fix Version/s 5.3.6 [ 12322961 ]
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.3.6 [ 12322961 ]
        Fix Version/s 5.3.5 [ 12322440 ]
        Howard M. Lewis Ship made changes -
        Labels fixed-in-5.4-js-rewrite
        Fix Version/s 5.3.5 [ 12322440 ]
        Priority Major [ 3 ] Critical [ 2 ]
        Hide
        Howard M. Lewis Ship added a comment -

        Easy enough to reproduce.

        Show
        Howard M. Lewis Ship added a comment - Easy enough to reproduce.
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Thomas Scheinecker created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Thomas Scheinecker
          • Votes:
            6 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development