[TAP5-1973] In certain development cases when switching from insecure to secure, BaseURLSource will still include :443 in the URL

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3.4, 5.4
• Fix Version/s: 5.4
• Component/s: tapestry-core
• Labels: fixed-in-5.4-js-rewrite
• Assignee: Howard Lewis Ship
• Reporter: Howard Lewis Ship
• Created: 11/Jul/12 00:56
• Updated: 02/Aug/14 04:21
• Resolved: 01/Aug/14 23:54

Description

An error in the code means that when secure is true and the port is set to 443, then ":443" is appended:

int port = secure ? secureHostPort : hostPort;
String portSuffix = "";

if (port <= 0)

{ port = request.getServerPort(); int schemeDefaultPort = request.isSecure() ? 443 : 80; portSuffix = port == schemeDefaultPort ? "" : ":" + port; }

else if (secure && port != 443) portSuffix = ":" + port;
else if (port != 80) portSuffix = ":" + port;

String hostname = "".equals(this.hostname) ? request.getServerName() : this.hostname.startsWith("$") ? System.getenv(this.hostname.substring(1)) : this.hostname;

return String.format("%s://%s%s", secure ? "https" : "http", hostname, portSuffix);

secure == true && port != 443 is false, so
port != 80 is evaluated, it true, so
":443" is appended.

Issue Links

• is cloned by: TAP5-2366 Backport: In certain development cases when switching from insecure to secure, BaseURLSource will still include :443 in the URL