[TAP5-1963] Original exception lost in CommitAfterWorker upon abort

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.3.3
• Fix Version/s: 5.3.4, 5.4
• Component/s: tapestry-hibernate
• Assignee: Howard Lewis Ship
• Reporter: Ben Dotte
• Created: 28/Jun/12 15:37
• Updated: 16/Dec/12 01:45
• Resolved: 29/Jun/12 22:36

Description

advise() in CommitAfterWorker surrounds the method invocation and session commit in a try/catch and runs manager.abort() if a RuntimeException is caught and then rethrows the RuntimeException. The problem is, depending on the original problem, it is not unlikely that manager.abort() itself could throw an exception (Transaction Not Started, Transaction Already Started, etc.). When that happens, the original RuntimeException is lost and all we get is the useless exception generated by the call to manager.abort().

I think we should just throw away any exceptions generated by manager.abort() so that we always retain the original RuntimeException. Something like this:

try
{
invocation.proceed();
// Success or checked exception:
manager.commit();
}
catch (RuntimeException ex)
{
try

{ manager.abort(); }

catch (Exception e)

{ // throw away; we want the real "ex" exception to get rethrown }

throw ex;
}