Tapestry 5
  1. Tapestry 5
  2. TAP5-1873

JavaScript execution exception is not logged

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.3.4, 5.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.

      Tapestry.js ajaxRequest @453:

      finalOptions.get('onException').call(this, response);

      Should be:

      finalOptions.get('onException').call(this, response, e);

      Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.

      Tapestry.js ajaxExceptionHandler @371:

      Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
      if(exception.stack)

      { Tapestry.debug(exception.stack); }

        Activity

        Hide
        Denis Stepanov added a comment -

        Should I create a patch or the description is enough? It's only few lines of code.

        Show
        Denis Stepanov added a comment - Should I create a patch or the description is enough? It's only few lines of code.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Denis Stepanov
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development