Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-1854

AjaxComponentEventRequestHandler doesn't handle the case where a response has already be returned, and may append an empty JSON Object to the response

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3.3, 5.4
    • Component/s: tapestry-core
    • Labels:
      None
    • Environment:
      WebSphere on linux, and Jetty on osx

      Description

      In committ 1155178 the removal of "if (resultProcessorInvoked.get()) return" seems to have reintroduced an old issue (#TAPESTRY-2619).
      When running on a Servlet engine that does not honor HttpResponse.getOutputStream().close() - i.e. subsequent writing to the responses outputstream will be written to the client - which is true for WebSphere but not for Jetty, the final line in AjaxComponentEventRequestHandler will write an new jsonobject to the response, resulting in an invalid json structure.

      My guess would be that the following block of code:
      -------------
      if ((!resultProcessorInvoked.get()) && queue.isPartialRenderInitialized())

      { partialRenderer.renderPartialPageMarkup(); return; }

      // Send an empty JSON reply if no value was returned from the component event handler method.
      // This is the typical behavior when an Ajax component event handler returns null.

      JSONObject reply = new JSONObject();

      resultProcessor.processResultValue(reply);
      }
      ---------------
      should be replaced with:
      ---------------
      if ((!resultProcessorInvoked.get()) && queue.isPartialRenderInitialized())
      { partialRenderer.renderPartialPageMarkup(); return; }

      // If the result processor was passed a value, then it will already have rendered, and there is nothing more to do.
      if (resultProcessorInvoked.get()) return;

      // Send an empty JSON reply if no value was returned from the component event handler method.
      // This is the typical behavior when an Ajax component event handler returns null.

      JSONObject reply = new JSONObject();

      resultProcessor.processResultValue(reply);
      }
      ------------------

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hlship Howard M. Lewis Ship
                Reporter:
                kai@systemfabrikken.no Kai Lilleby
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: