Tapestry 5
  1. Tapestry 5
  2. TAP5-1825

Incorrect order of parameter in localization messages within ValidationMessages Italian lang

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3.2, 5.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      We found some problem with the Italian localization of ValidationMessages.
      (T5.3.1 blows up)

      The problem is quite simple:

      From ValidationMessages.properties:
      maximum-string-length=You may provide at most %d characters for %s.
      From ValidationMessages_it.properties:
      maximum-string-length=Il campo %s può contenere al massimo %d caratteri.

      As you can see the order of parameter in the Italian wording is inverted.
      The fix is quite simple: the message format should specify the parameter index (like for instance in the German localization: maximum-string-length=%2$s darf höchstens %1$d Zeichen lang sein.)

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-5.3-freestyle #2 (See https://builds.apache.org/job/tapestry-5.3-freestyle/2/)
        Merge TAP5-1825 from trunk
        fix order of messages parameters from mailing list patch by Luca Menegus

        mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234019
        Files :

        • /tapestry/tapestry5/branches/5.3
        • /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/services/DelegatingRequest.java
        • /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_it.properties
        Show
        Hudson added a comment - Integrated in tapestry-5.3-freestyle #2 (See https://builds.apache.org/job/tapestry-5.3-freestyle/2/ ) Merge TAP5-1825 from trunk fix order of messages parameters from mailing list patch by Luca Menegus mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234019 Files : /tapestry/tapestry5/branches/5.3 /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/services/DelegatingRequest.java /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_it.properties
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #656 (See https://builds.apache.org/job/tapestry-trunk-freestyle/656/)
        TAP5-1825 fix order of messages parameters from mailing list patch by Luca Menegus

        mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234016
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_it.properties
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #656 (See https://builds.apache.org/job/tapestry-trunk-freestyle/656/ ) TAP5-1825 fix order of messages parameters from mailing list patch by Luca Menegus mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1234016 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/internal/ValidationMessages_it.properties

          People

          • Assignee:
            Massimo Lusetti
            Reporter:
            Massimo Lusetti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development