Tapestry 5
  1. Tapestry 5
  2. TAP5-1786

All forms/submission not working after FileUploadException is raised

    Details

      Description

      Hi,

      This is a blocker bug, when somebody uploaded a file that triggers a upload exception, all the forms submission trigger exception, and users from other places experience the same problem even he does not upload a file to trigger that, details:

      when configuration.add(UploadSymbols.FILESIZE_MAX, "200000"), this triggers following when your uploading file is bigger than 200000:

      org.apache.commons.fileupload.FileUploadBase$FileSizeLimitExceededException: The field file exceeds its maximum permitted size of 200000 bytes.
      at org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl$FileItemStreamImpl$1.raiseError(FileUploadBase.java:763)
      at org.apache.commons.fileupload.util.LimitedInputStream.checkLimit(LimitedInputStream.java:71)
      at org.apache.commons.fileupload.util.LimitedInputStream.read(LimitedInputStream.java:128)

      after that all the forms without using t:type="upload" in the application triggers:

      [INFO] AppModule.TimingFilter Request time: 11 ms
      [ERROR] TapestryModule.RequestExceptionHandler Processing of request failed with uncaught exception: Unable to decode multipart encoded request.
      java.lang.RuntimeException: Unable to decode multipart encoded request.
      at org.apache.tapestry5.upload.internal.services.UploadExceptionFilter.handle(UploadExceptionFilter.java:71)
      at $ComponentEventRequestHandler_125e4f941ab23906.handle(Unknown Source)
      at org.apache.tapestry5.services.TapestryModule$40.handle(TapestryModule.java:2454)

      and forms with t:type="upload", triggers following even file size is less than:

      org.apache.commons.fileupload.FileUploadBase$FileSizeLimitExceededException: The field file exceeds its maximum permitted size of 200000 bytes.
      at org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl$FileItemStreamImpl$1.raiseError(FileUploadBase.java:763)
      at org.apache.commons.fileupload.util.LimitedInputStream.checkLimit(LimitedInputStream.java:71)
      at org.apache.commons.fileupload.util.LimitedInputStream.read(LimitedInputStream.java:128)

      a discussion can be found here:

      http://tapestry.1045711.n5.nabble.com/T5-3-rc3-upload-exception-tc4989904.html

      1. test2.zip
        60 kB
        Angelo Chen

        Activity

        Hide
        Angelo Chen added a comment -

        upload form is in Contact,
        form without upload is in About,
        click Contact first, upload a file > 200k, then click 'about' to submit something.

        Show
        Angelo Chen added a comment - upload form is in Contact, form without upload is in About, click Contact first, upload a file > 200k, then click 'about' to submit something.
        Hide
        Howard M. Lewis Ship added a comment -

        File uploads a problematic in general because they leave the state of the current request in a partial and unknown state. There's no "just ignore the file upload and use the rest" because the file upload data is interspersed with the data for all the normal fields.

        Show
        Howard M. Lewis Ship added a comment - File uploads a problematic in general because they leave the state of the current request in a partial and unknown state. There's no "just ignore the file upload and use the rest" because the file upload data is interspersed with the data for all the normal fields.
        Hide
        Angelo Chen added a comment -

        this is related to https://issues.apache.org/jira/browse/TAP5-1765
        Dennis fix in 1765 fixes all the upload and form submission issues, TAP5-1765 causes some bugs difficult to trace as it seems not related, have tried t5.3.1 - rc1, and problem is fixed.

        Show
        Angelo Chen added a comment - this is related to https://issues.apache.org/jira/browse/TAP5-1765 Dennis fix in 1765 fixes all the upload and form submission issues, TAP5-1765 causes some bugs difficult to trace as it seems not related, have tried t5.3.1 - rc1, and problem is fixed.
        Show
        Angelo Chen added a comment - https://issues.apache.org/jira/browse/TAP5-1765
        Show
        Angelo Chen added a comment - https://issues.apache.org/jira/browse/TAP5-1765

          People

          • Assignee:
            Unassigned
            Reporter:
            Angelo Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development