Tapestry 5
  1. Tapestry 5
  2. TAP5-1773

FormFieldFocus mixin passes control name, not client id, to JavaScriptSupport.autofocus()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3, 5.4
    • Fix Version/s: 5.3.1, 5.4
    • Component/s: tapestry-core
    • Labels:

      Description

      Noticed this while writing up some documentation about dealing with form focus. This works in simple cases where the control name and the client id often are the same value, but won't work in other cases (especially Ajax ones).

      In addition, it is not clear why this mixin is attached to a Form and takes a Field as a parameter rather than attaching to a Field and taking no parameters?

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in tapestry-trunk-freestyle #638 (See https://builds.apache.org/job/tapestry-trunk-freestyle/638/)
          TAP5-1773 Add a new OverrideFieldFocus mixin which supersed and deprecate the old one FormFieldFocus

          mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212270
          Files :

          • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java
          • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/OverrideFieldFocus.java
          • /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/OverrideFieldFocusDemo.tml
          • /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/FormFieldFocusTest.groovy
          • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java
          • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/OverrideFieldFocusDemo.java
          Show
          Hudson added a comment - Integrated in tapestry-trunk-freestyle #638 (See https://builds.apache.org/job/tapestry-trunk-freestyle/638/ ) TAP5-1773 Add a new OverrideFieldFocus mixin which supersed and deprecate the old one FormFieldFocus mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212270 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/FormFieldFocus.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/mixins/OverrideFieldFocus.java /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/OverrideFieldFocusDemo.tml /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/FormFieldFocusTest.groovy /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/Index.java /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/OverrideFieldFocusDemo.java

            People

            • Assignee:
              Massimo Lusetti
              Reporter:
              Howard M. Lewis Ship
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development