[TAP5-1731] Dynamic loading of JavaScript libraries is sometimes broken in IE (in rare cases)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3
• Fix Version/s: 5.3
• Component/s: tapestry-core
• Labels: ie javascript
• Assignee: Howard Lewis Ship
• Reporter: Howard Lewis Ship
• Created: 27/Oct/11 18:24
• Updated: 27/Oct/11 20:56
• Resolved: 27/Oct/11 19:11

Description

Problem is in this code:

addScripts : function(scripts, callback) {

var _ = T5._;

var loaded = _(document.scripts).chain().pluck("src").without("").map(this.rebuildURLIfIE).value();

var topCallback = _(scripts).chain().map(Tapestry.rebuildURL).difference(loaded).reverse().reduce(
function (nextCallback, scriptURL) {
return function()

{ this.loadScript(scriptURL, nextCallback); }

}, callback).value();

// Kick if off with the callback that loads the first script:

topCallback.call(this);
},

In the nested callback, the "this" variable is not set to the right value, at least not inside ie. Need to fully qualify (Tapestry.ScriptLoader.loadScript()) or other bind this.