Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-1706

JS syntax error in Tapestry.ajaxRequest() when Ajax fails

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.3, 5.2.6
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      In tapestry.js the JS Tapestry.ajaxRequest() method accesses the finalOptions variable incorrectly.

      It is a prototype $H Hash, not an array, and so must be accessed as such:

      finalOptions.toObject().onFailure.call(this, response);

      and not

      finalOptions.onFailure.call(this, response);

      Attached is a patch for this...

      ...although looking at the docs - http://api.prototypejs.org/language/dollar-H/ - a more optimal approach may be

      finalOptions.get('onFailure').call(this, response);

        Attachments

          Activity

            People

            • Assignee:
              hlship Howard M. Lewis Ship
              Reporter:
              slimerdude Steve Eynon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: