Tapestry 5
  1. Tapestry 5
  2. TAP5-1700

Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.

      In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.

      This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #602 (See https://builds.apache.org/job/tapestry-trunk-freestyle/602/)
        TAP5-1700: Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188198
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ajax/AjaxResponseRenderer.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #602 (See https://builds.apache.org/job/tapestry-trunk-freestyle/602/ ) TAP5-1700 : Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188198 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ajax/AjaxResponseRenderer.java
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Howard M. Lewis Ship made changes -
        Summary The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Adam made changes -
        Field Original Value New Value
        Attachment forminjector53.txt [ 12499689 ]
        Hide
        Adam added a comment -

        Here's a patch that adds the filter to the queue before calling triggerEvent.

        Show
        Adam added a comment - Here's a patch that adds the filter to the queue before calling triggerEvent.
        Adam created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Adam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development