Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: tapestry-test
    • Labels:
      None

      Description

      The current version of Selenium only works with older browsers. Selenium 2.3.1 is almost a drop in replacement and will allow tests to be run with Firefox 5. At least on my setup, Selenium 2.3.1 is not significantly slower and is sometimes faster than the current version. Below are the test times running on Ubuntu 11.04.

      Firefox 5:

      5.3 Selenium 2 & Gradle
      6:47
      6:42
      Using Firefox 3.6:

      5.2.6 Selenium 1 & Maven
      6:14

      5.3 with Selenium 1 & Gradle
      7:05
      7:14

      5.3 Selenium 2 & Gradle
      7:26
      8:01

        Activity

        Mark Shead created issue -
        Mark Shead made changes -
        Field Original Value New Value
        Comment [ Here is a simple patch that switches to Selenium 2.3.1. It doesn't try to take advantage of the new WebDriver capabilities--only replace the current version with one that will handle more modern browsers. ]
        Mark Shead made changes -
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Hide
        Howard M. Lewis Ship added a comment -

        I've gone through this with a client, and one thing that happened is that existing tests, against the Selenium 1 api, slowed down considerably.

        Show
        Howard M. Lewis Ship added a comment - I've gone through this with a client, and one thing that happened is that existing tests, against the Selenium 1 api, slowed down considerably.
        Hide
        Mark Shead added a comment -

        Here is a patch that switches tapestry-test to use Selenium 2.3.1. It is the changes I made that produced the test times I listed.

        Show
        Mark Shead added a comment - Here is a patch that switches tapestry-test to use Selenium 2.3.1. It is the changes I made that produced the test times I listed.
        Mark Shead made changes -
        Attachment PATCH-TAP5-1599 [ 12489865 ]
        Hide
        Mark Shead added a comment -

        Howard - If you look at the test times, you'll see that did not happen in my tests. In fact it appears that the tests can even run faster using Selenium 2.3.1 and FF 5. Perhaps there are certain circumstances or certain setups where they will run slower. I can try running the tests on some other platforms to see if I run into any problems there.

        Show
        Mark Shead added a comment - Howard - If you look at the test times, you'll see that did not happen in my tests. In fact it appears that the tests can even run faster using Selenium 2.3.1 and FF 5. Perhaps there are certain circumstances or certain setups where they will run slower. I can try running the tests on some other platforms to see if I run into any problems there.
        Kalle Korhonen made changes -
        Assignee Kalle Korhonen [ kaosko ]
        Hide
        Kalle Korhonen added a comment -

        Evaluating the patch.. test run time 6:24 for me on Windows. I think we should put it in but I'll also take a crack at fixing the failing tests as part of this issue.

        Show
        Kalle Korhonen added a comment - Evaluating the patch.. test run time 6:24 for me on Windows. I think we should put it in but I'll also take a crack at fixing the failing tests as part of this issue.
        Howard M. Lewis Ship made changes -
        Assignee Kalle Korhonen [ kaosko ] Howard M. Lewis Ship [ hlship ]
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #468 (See https://builds.apache.org/job/tapestry-trunk-freestyle/468/)
        TAP5-1599: Adjust for slight difference in how disabled fields are reported under Selenium 2
        TAP5-1599: Commit patch to move to Selenium 2.3.1 (note: some test failures)

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156705
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156704
        Files :

        • /tapestry/tapestry5/trunk/tapestry-test/build.gradle
        • /tapestry/tapestry5/trunk/tapestry-test/src/test/java/org/apache/tapestry5/test/SanityCheckTestSuite.java
        • /tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/AbstractIntegrationTestSuite.java
        • /tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #468 (See https://builds.apache.org/job/tapestry-trunk-freestyle/468/ ) TAP5-1599 : Adjust for slight difference in how disabled fields are reported under Selenium 2 TAP5-1599 : Commit patch to move to Selenium 2.3.1 (note: some test failures) hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156705 Files : /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156704 Files : /tapestry/tapestry5/trunk/tapestry-test/build.gradle /tapestry/tapestry5/trunk/tapestry-test/src/test/java/org/apache/tapestry5/test/SanityCheckTestSuite.java /tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/AbstractIntegrationTestSuite.java /tapestry/tapestry5/trunk/tapestry-test/src/main/java/org/apache/tapestry5/test/SeleniumTestCase.java
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        22d 4h 14m 1 Howard M. Lewis Ship 31/Aug/11 18:56

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Mark Shead
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development