Tapestry 5
  1. Tapestry 5
  2. TAP5-1581

MarkupWriterImpl makes many, many defensive copies of its listener list

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.3, 5.2
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:

      Description

      It currently makes defensive copies before iterating over its listeners, to guard against adds or removes during the iteration. CopyOnWriteArrayList would bypass the need for defensive copying.

        Activity

        Howard M. Lewis Ship created issue -
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #423 (See https://builds.apache.org/job/tapestry-trunk-freestyle/423/)
        TAP5-1581: MarkupWriterImpl makes many, many defensive copies of its listener list

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148600
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/MarkupWriterImpl.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #423 (See https://builds.apache.org/job/tapestry-trunk-freestyle/423/ ) TAP5-1581 : MarkupWriterImpl makes many, many defensive copies of its listener list hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148600 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/MarkupWriterImpl.java
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        33m 2s 1 Howard M. Lewis Ship 20/Jul/11 02:53

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development