[TAP5-1545] Submit component should be able to render as button type="submit"

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 5.2
• Component/s: tapestry-core
• Labels: bulk-close-candidate
• Assignee: Unassigned
• Reporter: nillehammer
• Created: 11/Jun/11 15:43
• Updated: 12/Jan/15 08:10
• Resolved: 12/Jan/15 08:10

Description

The Submit component renders an <input type="submit">. Since Html 4.0 it is possible to markup the submit button as what it is, a button. The HTML markup is <button type="submit">. I prefer this approach, because it makes styling easier. One could use a general CSS-styling for input-Elements (e.g. common width, special fonts etc.). And the submit button won't be affected.

To make this change backwards compatible, an optional parameter could be used in org.apache.tapestry5.corelib.components.Submit. The code:

@Parameter(value="false", defaultPrefix = BindingConstants.LITERAL)
private boolean renderAsButton;

And in the method beginRende()r:

if (renderAsButton) {
writer.element("button",
"type", "submit",
"name", name,
"id", clientId);
if (image !=null)

{ writer.element("img", "src", image.toClientURL()); writer.end(); }

}
else {
//... do the usual rentering of input type submit
}

Thanks in advance and cheers to the commiters,
nillehammer