Tapestry 5
  1. Tapestry 5
  2. TAP5-1521

JavaScriptSupport.addInitializerCall() should support JSONArray of function parameters, as RenderSupport does

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3, 5.2.5
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      JavaScriptSupport does not support addInitializerCall(String,JSONArray), which is supported by RenderSupport. This was intentional, as using a JSONObject (with named key/values) is less likely to cause problems coordinating server-side Java code with client-side JavaScript code.

      However, it can be unwieldy and verbose as well. Therefore, it should be re-implemented efficiently ... RenderSupport.addInit(String,JSONArray) still works, but is implemented in a very inefficient way. Instead, it should pass through to new method JavaScriptSupport.addInitializerCall(String,JSONArray).

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #441 (See https://builds.apache.org/job/tapestry-trunk-freestyle/441/)
        TAP5-1521: Add test for basic traditional (non-Ajax) alerts

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152050
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #441 (See https://builds.apache.org/job/tapestry-trunk-freestyle/441/ ) TAP5-1521 : Add test for basic traditional (non-Ajax) alerts hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152050 Files : /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development