Tapestry 5
  1. Tapestry 5
  2. TAP5-1475

In a multipart file upload, request parameters in the URL are not exposed, only parameters in the request body

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: tapestry-upload
    • Labels:
      None

      Description

      Adds parameters from URL to the parameter map. Currently if you upload a multipart file using POST e.g. POST www.server.com/webapp/page?t:ac=1 the t:ac parameter is not seen and the empty activation context is used. This patch fixes that issue.

        Activity

        Tom van Dijk created issue -
        Tom van Dijk made changes -
        Field Original Value New Value
        Attachment 0001-tapestry-upload-now-include-parameters-from-POST-que.patch [ 12473698 ]
        Tom van Dijk made changes -
        Attachment 0001-tapestry-upload-now-include-parameters-from-POST-que.patch [ 12473698 ]
        Tom van Dijk made changes -
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Summary Let getParameters() and related methods also show parameters from URL query In a multipart file upload, request parameters in the URL are not exposed, only parameters in the request body
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #591 (See https://builds.apache.org/job/tapestry-trunk-freestyle/591/)
        TAP5-1475: In a multipart file upload, request parameters in the URL are not exposed, only parameters in the request body

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186366
        Files :

        • /tapestry/tapestry5/trunk/tapestry-upload/src/main/java/org/apache/tapestry5/upload/internal/services/MultipartDecoderImpl.java
        • /tapestry/tapestry5/trunk/tapestry-upload/src/test/java/org/apache/tapestry5/upload/internal/services/MultipartDecoderImplTest.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #591 (See https://builds.apache.org/job/tapestry-trunk-freestyle/591/ ) TAP5-1475 : In a multipart file upload, request parameters in the URL are not exposed, only parameters in the request body hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186366 Files : /tapestry/tapestry5/trunk/tapestry-upload/src/main/java/org/apache/tapestry5/upload/internal/services/MultipartDecoderImpl.java /tapestry/tapestry5/trunk/tapestry-upload/src/test/java/org/apache/tapestry5/upload/internal/services/MultipartDecoderImplTest.java

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Tom van Dijk
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development