Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: tapestry-ioc
    • Labels:
      None

      Description

      For the implementation of tapestry-hibernate with multiple databases I need to be able to see whether certain services are realized or not.

      The attached patch improves ServiceActivityScoreboard in two ways.

      • ServiceActivity interface now includes getMarkers() (which calls serviceDef.getMarkers())
      • ServiceActivity now correctly handles perthread services.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        146d 2h 40m 1 Kalle Korhonen 17/Mar/11 21:40
        Resolved Resolved Closed Closed
        153d 32m 1 Howard M. Lewis Ship 17/Aug/11 22:12
        Howard M. Lewis Ship made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.3 [ 12316024 ]
        Fix Version/s 5.3.0 [ 12316023 ]
        Hide
        Hudson added a comment -

        Integrated in tapestry-5.2-freestyle #293 (See https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/293/)
        TAP5-1320: Applied Tom van Dijk's patch for adding getMarkers() and
        perthread service support to ServiceActivity without changes

        Show
        Hudson added a comment - Integrated in tapestry-5.2-freestyle #293 (See https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/293/ ) TAP5-1320 : Applied Tom van Dijk's patch for adding getMarkers() and perthread service support to ServiceActivity without changes
        Kalle Korhonen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 5.3.0 [ 12316023 ]
        Resolution Fixed [ 1 ]
        Hide
        Kalle Korhonen added a comment -

        Applied, thanks to Tom for a high quality patch. Howard's comment might be a useful improvement to the page should be dealt as a separate issue, closing.

        Show
        Kalle Korhonen added a comment - Applied, thanks to Tom for a high quality patch. Howard's comment might be a useful improvement to the page should be dealt as a separate issue, closing.
        Tom van Dijk made changes -
        Attachment ServiceActivity-now-correct-for-perthread-values-plu.patch [ 12473157 ]
        Tom van Dijk made changes -
        Attachment ServiceActivity.patch [ 12473834 ]
        Hide
        Tom van Dijk added a comment -

        This one has tests

        Show
        Tom van Dijk added a comment - This one has tests
        Hide
        Howard M. Lewis Ship added a comment -

        At some point, I'd like to fix up this page to use a more ajax style: a left pane listing the services, and a right pane with all the details for the selected service.

        Show
        Howard M. Lewis Ship added a comment - At some point, I'd like to fix up this page to use a more ajax style: a left pane listing the services, and a right pane with all the details for the selected service.
        Hide
        Kalle Korhonen added a comment -

        Unit test missing, see comments on mailing list

        Show
        Kalle Korhonen added a comment - Unit test missing, see comments on mailing list
        Kalle Korhonen made changes -
        Assignee Kalle Korhonen [ kaosko ]
        Tom van Dijk made changes -
        Attachment 0001-ServiceActivity-now-correct-for-perthread-values-plu.patch [ 12458593 ]
        Tom van Dijk made changes -
        Attachment ServiceActivity-now-correct-for-perthread-values-plu.patch [ 12473157 ]
        Tom van Dijk made changes -
        Attachment serviceactivity.diff [ 12457860 ]
        Tom van Dijk made changes -
        Attachment 0001-ServiceActivity-now-correct-for-perthread-values-plu.patch [ 12458593 ]
        Hide
        Tom van Dijk added a comment -

        Here is the patch file (using git format-patch)

        Show
        Tom van Dijk added a comment - Here is the patch file (using git format-patch)
        Tom van Dijk made changes -
        Field Original Value New Value
        Attachment serviceactivity.diff [ 12457860 ]
        Tom van Dijk created issue -

          People

          • Assignee:
            Kalle Korhonen
            Reporter:
            Tom van Dijk
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development