[TAP5-1138] ClassTransformation deprecated a bunch of methods, then refers to replacements that don't exist

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.2.0
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Pierce Wetter
• Created: 08/May/10 20:07
• Updated: 14/May/10 22:32
• Resolved: 14/May/10 22:32

Description

ClassTransformation both deprecated and REMOVED several methods, like extendMethod, addMethod, etc.

First, while deprecating is fine, removal is a bad habit. Why not just change the implementation to use the new approach?

i.e.:

if this is what extendMethod turns into:

method = transformation.getOrCreateMethod(TransformConstants.BEGIN_RENDER_SIGNATURE);
method.extend(
tokenField.getName() + " = " + interField
+ ".checkBefore(" + configField + ");"
);

Then just put that code in extend method.

Second, there is no new approach! extendMethod suggests using TransformMethod.extend, but there is no TransformMethod.extend.

Note: Discovered while attempting to port tapestry-spring-security to 5.2.0-SNAPSHOT

Issue Links

• is part of: TAP5-853 Move away from Javassist