Tapestry 5
  1. Tapestry 5
  2. TAP5-1138

ClassTransformation deprecated a bunch of methods, then refers to replacements that don't exist

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      ClassTransformation both deprecated and REMOVED several methods, like extendMethod, addMethod, etc.

      First, while deprecating is fine, removal is a bad habit. Why not just change the implementation to use the new approach?

      i.e.:

      if this is what extendMethod turns into:

      method = transformation.getOrCreateMethod(TransformConstants.BEGIN_RENDER_SIGNATURE);
      method.extend(
      tokenField.getName() + " = " + interField
      + ".checkBefore(" + configField + ");"
      );

      Then just put that code in extend method.

      Second, there is no new approach! extendMethod suggests using TransformMethod.extend, but there is no TransformMethod.extend.

      Note: Discovered while attempting to port tapestry-spring-security to 5.2.0-SNAPSHOT

        Issue Links

          Activity

          Hide
          Pierce Wetter added a comment -

          I'm guessing that the changes as part of 853 caused this problem.

          Show
          Pierce Wetter added a comment - I'm guessing that the changes as part of 853 caused this problem.

            People

            • Assignee:
              Howard M. Lewis Ship
              Reporter:
              Pierce Wetter
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development