Tapestry 5
  1. Tapestry 5
  2. TAP5-11

CookiesImplTest does specify a domain cookie with a domain not prefixed with a . (dot)

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.2, 5.1.0.7, 5.0.19
    • Fix Version/s: 5.2.0
    • Component/s: None
    • Labels:
      None

      Description

      CookiesImplTest does specify a domain cookie with a domain not prefixed with a . (dot) where the RFC 2109 explicitly says it should always do.

        Activity

        Jochen Kemnade made changes -
        Fix Version/s 5.1.0.8 [ 12314520 ]
        Jochen Kemnade made changes -
        Fix Version/s 5.0.20 [ 12314490 ]
        Howard M. Lewis Ship made changes -
        Issue Type Bug [ 1 ] Task [ 3 ]
        Ulrich Stärk made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ulrich Stärk made changes -
        Original Estimate 0h [ 0 ]
        Remaining Estimate 0h [ 0 ]
        Assignee Ulrich Stärk [ ulrich.staerk ]
        Fix Version/s 5.1.0.8 [ 12314520 ]
        Fix Version/s 5.2.0 [ 12314122 ]
        Fix Version/s 5.0.20 [ 12314490 ]
        Affects Version/s 5.1.0.7 [ 12314494 ]
        Affects Version/s 5.2 [ 12313900 ]
        Affects Version/s 5.0.19 [ 12313570 ]
        Affects Version/s 5.0.15 [ 12313429 ]
        Howard M. Lewis Ship made changes -
        Affects Version/s 5.0.15 [ 12313429 ]
        Howard M. Lewis Ship made changes -
        Affects Version/s 5.0 [ 12312018 ]
        Key TAPESTRY-1251 TAP5-11
        Project Tapestry [ 10573 ] Tapestry 5 [ 12310833 ]
        Hide
        Massimo Lusetti added a comment -

        The statement at line 144: assertEquals(cookies.get(0), expectedCookie); doesn't take into account the domain part of the cookie.
        Actually is the equals method of Cookie which probably doesn't, anyhow even commenting out line 142: expectedCookie.setDomain("fobar.com"); doesn't make the test fail.

        So it's probably better to add something like: assertEquals(cookies.get(0).getDomain(), expectedCookie.getDomain()); as final assert for testing domain wide cookies.

        Show
        Massimo Lusetti added a comment - The statement at line 144: assertEquals(cookies.get(0), expectedCookie); doesn't take into account the domain part of the cookie. Actually is the equals method of Cookie which probably doesn't, anyhow even commenting out line 142: expectedCookie.setDomain("fobar.com"); doesn't make the test fail. So it's probably better to add something like: assertEquals(cookies.get(0).getDomain(), expectedCookie.getDomain()); as final assert for testing domain wide cookies.
        Massimo Lusetti made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Trivial [ 5 ]
        Massimo Lusetti created issue -

          People

          • Assignee:
            Ulrich Stärk
            Reporter:
            Massimo Lusetti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development