Tapestry 5
  1. Tapestry 5
  2. TAP5-1057

XSS vulnerability in calendar component

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.5
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-core
    • Labels:

      Description

      The calendar component provided in tapestry 5.1.0.5 could be used to allow code injection by malicious web users into any page that uses datefield .

      To reproduce the vulnerability, put js code like <script>alert("T5 is great"); </script> in any datefield and click on the related calendar bitma

      After quick search in the DateField.js, it seems like the field value is not escaping

      escaping with a change like var value = escape($F(this.field)); the field value seems solve this vulnerability.

      1. datefield_js.patch
        1 kB
        Nourredine K.
      2. datefield_js.patch
        0.7 kB
        Nourredine K.

        Issue Links

          Activity

          Christophe Cordenier made changes -
          Link This issue is cloned as TAP5-1262 [ TAP5-1262 ]
          Christophe Cordenier made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Christophe Cordenier made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Assignee Igor Drobiazko [ igor.drobiazko ] Christophe Cordenier [ ccordenier ]
          Igor Drobiazko made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Fix Version/s 5.2.0 [ 12314122 ]
          Resolution Fixed [ 1 ]
          Igor Drobiazko made changes -
          Assignee Igor Drobiazko [ igor.drobiazko ]
          Nourredine K. made changes -
          Attachment datefield_js.patch [ 12443048 ]
          François Facon made changes -
          Labels XSS
          Nourredine K. made changes -
          Field Original Value New Value
          Attachment datefield_js.patch [ 12439043 ]
          François Facon created issue -

            People

            • Assignee:
              Christophe Cordenier
              Reporter:
              François Facon
            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development