Tapestry 5
  1. Tapestry 5
  2. TAP5-1047

@IncludeJavaScriptLibrary and @IncludeStylesheet may incorrectly calculate resources in component sub-classes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.0
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      The recent refactoring of ComponentClassTransformWorkers is suspect. I believe that the workers for the two annotations are using the component;s componentResources to get to the base resource, rather than capturing the correct base resource at transformation time. The former means that the base resource used is derived from the subclass, the latter is that the base resource is derived (correctly) from the super-class.

        Activity

        Hide
        Howard M. Lewis Ship added a comment -
        • The @Override methods (eg. generateResponseMarkup(MarkupWriter writer, List matches)) are no longer called on the extending class

        I can't see this as being true; it's clearly in the code that the method is being called and can be overridden.

        Show
        Howard M. Lewis Ship added a comment - The @Override methods (eg. generateResponseMarkup(MarkupWriter writer, List matches)) are no longer called on the extending class I can't see this as being true; it's clearly in the code that the method is being called and can be overridden.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Joost Schouten
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development