[TAMAYA-198] tamaya-formats blindly tries (and failes) to parse a config file with multiple formats

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3-incubating
• Fix Version/s: 0.3-incubating
• Component/s: Extensions
• Assignee: Anatole Tresch
• Reporter: Thomas Liebetraut
• Created: 18/Nov/16 17:14
• Updated: 18/Sep/17 19:35
• Resolved: 19/Dec/16 22:39

Description

BaseFormatPropertySourceProvider can handle multiple formats registered. This is useful in my project because we actually support multiple formats for a certain type of config file and this way we can implement one Provider which can provide PropertySources for all of them.

But getPropertySources() will

1. blindly try all files with all formats. E.g. if both, "properties" and "ini" formats are registered, it will try all files with both formats without checking format.accepts() first.
2. try all the formats with the same InputStream. If the previous format does not reset the input stream, it is already at the end of the file and the following formats don't have anything left to read, returning null. This leads to some {{NullPointerException}}s being logged.