Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-981

Help command (\?) in tsql takes too long time.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      HelpCommand class firstly retrieves the documentation in tajo.apache.org. Its approach looks good. But, it is likely to take too long time (usually 1-3 seconds) at first time. We should resolve it or remove it.

      try {
              URL u = new URL("http://tajo.apache.org/docs/"+ tajoVersion + "/");
              HttpURLConnection huc =  (HttpURLConnection) u.openConnection();
              huc.setConnectTimeout(1000);
              huc.setReadTimeout(1000);
              huc.setRequestMethod("HEAD");
              if(huc.getResponseCode() == HttpURLConnection.HTTP_OK) {
                docVersion = tajoVersion;
              } else {
                docVersion = docDefaultVersion;
              }
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hys9958 opened a pull request:

        https://github.com/apache/tajo/pull/174

        TAJO-981: Help command (?) in tsql takes too long time.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hys9958/tajo tajo-981

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/174.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #174


        commit 737d2122cb54b8404a741a6979cfbc2dc11e3ea0
        Author: hys9958 <hanyounsu@gmail.com>
        Date: 2014-09-30T21:19:48Z

        TAJO-981: Help command (?) in tsql takes too long time.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hys9958 opened a pull request: https://github.com/apache/tajo/pull/174 TAJO-981 : Help command (?) in tsql takes too long time. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hys9958/tajo tajo-981 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/174.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #174 commit 737d2122cb54b8404a741a6979cfbc2dc11e3ea0 Author: hys9958 <hanyounsu@gmail.com> Date: 2014-09-30T21:19:48Z TAJO-981 : Help command (?) in tsql takes too long time.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/174#issuecomment-57428918

        +1

        Hi @hys9958
        Thank you for your contribution.
        It looks good to me and it ran as expected on test cluster.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/174#issuecomment-57428918 +1 Hi @hys9958 Thank you for your contribution. It looks good to me and it ran as expected on test cluster.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/174

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/174
        Hide
        blrunner Jaehwa Jung added a comment -

        I've just committed the patch to master branch.

        Show
        blrunner Jaehwa Jung added a comment - I've just committed the patch to master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #381 (See https://builds.apache.org/job/Tajo-master-build/381/)
        TAJO-981: Help command (?) in tsql takes too long time. (YeonSu Han via jaehwa) (blrunner: rev 0356a5257cd2426d783642e27478eaae95ddfe7d)

        • tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #381 (See https://builds.apache.org/job/Tajo-master-build/381/ ) TAJO-981 : Help command (?) in tsql takes too long time. (YeonSu Han via jaehwa) (blrunner: rev 0356a5257cd2426d783642e27478eaae95ddfe7d) tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #23 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/23/)
        TAJO-981: Help command (?) in tsql takes too long time. (YeonSu Han via jaehwa) (blrunner: rev 0356a5257cd2426d783642e27478eaae95ddfe7d)

        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #23 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/23/ ) TAJO-981 : Help command (?) in tsql takes too long time. (YeonSu Han via jaehwa) (blrunner: rev 0356a5257cd2426d783642e27478eaae95ddfe7d) CHANGES tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-block_iteration-branch-build #12 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/12/)
        TAJO-981: Help command (?) in tsql takes too long time. (YeonSu Han via jaehwa) (blrunner: rev 0356a5257cd2426d783642e27478eaae95ddfe7d)

        • tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-block_iteration-branch-build #12 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/12/ ) TAJO-981 : Help command (?) in tsql takes too long time. (YeonSu Han via jaehwa) (blrunner: rev 0356a5257cd2426d783642e27478eaae95ddfe7d) tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java CHANGES

          People

          • Assignee:
            hys9958 YeonSu Han
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development