Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-974

Eliminate unexpected case condition in SubQuery

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: distributed query plan
    • Labels:
      None

      Description

      Please take a loot at the below code. In SubQuery::calculateShuffleOutputNum() method, if-condition will be passed through the unexpected case if the plan is neither group by and join. In current implementation, distinct group-by operator can cause this case. Actually, the below code is messy. We need to directly handle distinct group by and clean up the below code.

      "SubQuery::calculateShuffleOutputNum()"
      } else {
              LOG.info("============>>>>> Unexpected Case! <<<<<================");
              long volume = getInputVolume(subQuery.masterPlan, subQuery.context, subQuery.block);
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/93

        TAJO-974: Eliminate unexpected case condition in SubQuery

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-974

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/93.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #93


        commit 6463f8d7299f582ab8806b57691f5c3766803ebc
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-07-24T15:49:32Z

        TAJO-974: Eliminate unexpected case condition in SubQuery

        commit 5542dc9a0a2382b877a0ffc2e314e2a8f2823426
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-07-24T15:49:57Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/93 TAJO-974 : Eliminate unexpected case condition in SubQuery You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-974 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit 6463f8d7299f582ab8806b57691f5c3766803ebc Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-07-24T15:49:32Z TAJO-974 : Eliminate unexpected case condition in SubQuery commit 5542dc9a0a2382b877a0ffc2e314e2a8f2823426 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-07-24T15:49:57Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/93#issuecomment-50294216

        +1
        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/93#issuecomment-50294216 +1 The patch looks good to me.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #315 (See https://builds.apache.org/job/Tajo-master-build/315/)
        TAJO-974: Eliminate unexpected case condition in SubQuery. (Hyoungjun Kim via hyunsik) (hyunsik: rev 1f6b5b38752f499ee6d70ea1be399df34442b4f3)

        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #315 (See https://builds.apache.org/job/Tajo-master-build/315/ ) TAJO-974 : Eliminate unexpected case condition in SubQuery. (Hyoungjun Kim via hyunsik) (hyunsik: rev 1f6b5b38752f499ee6d70ea1be399df34442b4f3) tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java CHANGES
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/93

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/93
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #316 (See https://builds.apache.org/job/Tajo-master-build/316/)
        TAJO-974: Eliminate unexpected case condition in SubQuery. (missed ticket close) (hyunsik: rev 3cfc1987e69130fa0232d09765c5c3582914884c)

        • CHANGES
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #316 (See https://builds.apache.org/job/Tajo-master-build/316/ ) TAJO-974 : Eliminate unexpected case condition in SubQuery. (missed ticket close) (hyunsik: rev 3cfc1987e69130fa0232d09765c5c3582914884c) CHANGES

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development