Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-972

Broadcast join with left outer join returns duplicated rows.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      If LEFT OUTER JOIN has broadcast table and broadcast target table is left side, every tasks run join operation with all rows in broadcast table. So some tasks match and other tasks doesn't match.
      For example:

      default>select * from small
      id
      -----------------
      1
      2
      3
      
      default>select * from large
      1
      4    <-- Block1 in HDFS
      5
      ...
      2    <-- Block2 in HDFS
      6
      
      default> select a.id, b.id from small a left outer join large b on a.id = b.id
      a.id    b.id
      ---------------------------
      1  1
      2  null
      3  null
      1  null
      2  2
      3  null
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/89

        TAJO-972: Broadcast join with left outer join returns duplicated rows.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-972

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/89.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #89


        commit e391b87215d139be0309e1b120dda412b70d9e9c
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-07-22T11:23:55Z

        TAJO-972: Broadcast join with left outer join returns duplicated rows.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/89 TAJO-972 : Broadcast join with left outer join returns duplicated rows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-972 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit e391b87215d139be0309e1b120dda412b70d9e9c Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-07-22T11:23:55Z TAJO-972 : Broadcast join with left outer join returns duplicated rows.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/89#issuecomment-49826247

        +1

        Thanks your contribution, it looks good overall.
        I'll push it now.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/89#issuecomment-49826247 +1 Thanks your contribution, it looks good overall. I'll push it now.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/89

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/89
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #311 (See https://builds.apache.org/job/Tajo-master-build/311/)
        TAJO-972: Broadcast join with left outer join returns duplicated rows.(Hyoungjun Kim via jaehwa) (blrunner: rev a5de837209a8d6d9685ad1aa8132b3b4ecd99727)

        • tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/global/TestBroadcastJoinPlan.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #311 (See https://builds.apache.org/job/Tajo-master-build/311/ ) TAJO-972 : Broadcast join with left outer join returns duplicated rows.(Hyoungjun Kim via jaehwa) (blrunner: rev a5de837209a8d6d9685ad1aa8132b3b4ecd99727) tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/global/TestBroadcastJoinPlan.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        already committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - already committed it to master branch.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development