Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-956

CONCAT should be support multiple params and null param.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently Tajo's CONCAT function doesn't support multiple parameters and null parameter.

      default> select concat('aaa', 'bbb', 'ccc');
      ERROR: function concat(text,text,text) does not exist
      default>
      

      CONCAT function can be defined as follows.

      default> select concat(null, 'aaa', null, 'bbb', 'ccc');
       concat
      --------
       aaabbbccc
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/81

        TAJO-956: CONCAT should be support multiple params and null param.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-956

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/81.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #81


        commit f6a5b60b7a27524c55a651b78adc813a92300b76
        Author: 김형준 <babokim@babokim-mbp.server.gruter.com>
        Date: 2014-07-18T04:32:44Z

        TAJO-956: CONCAT should be support multiple params and null param.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/81 TAJO-956 : CONCAT should be support multiple params and null param. You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-956 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit f6a5b60b7a27524c55a651b78adc813a92300b76 Author: 김형준 <babokim@babokim-mbp.server.gruter.com> Date: 2014-07-18T04:32:44Z TAJO-956 : CONCAT should be support multiple params and null param.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/81#issuecomment-49545196

        +1

        The patch looks good to me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/81#issuecomment-49545196 +1 The patch looks good to me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/81

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/81
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #304 (See https://builds.apache.org/job/Tajo-master-build/304/)
        TAJO-956: CONCAT should be support multiple params and null param. (Hyoungjun Kim via hyunsik) (hyunsik: rev 06935b392ce40264ae41e6486e5737f8c5c0593b)

        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/string/Concat.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #304 (See https://builds.apache.org/job/Tajo-master-build/304/ ) TAJO-956 : CONCAT should be support multiple params and null param. (Hyoungjun Kim via hyunsik) (hyunsik: rev 06935b392ce40264ae41e6486e5737f8c5c0593b) tajo-core/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java tajo-core/src/main/java/org/apache/tajo/engine/function/string/Concat.java CHANGES

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development