Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-952

Wrong default partition volume config

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: distributed query plan
    • Labels:
      None

      Description

      The following config is wrong. The config name has the suffix '-mb', but its default value seens to mean the number of bytes. It should be fixed. In addition, the part using this config may need calculatation from mb to bytes.

      DIST_QUERY_TABLE_PARTITION_VOLUME("tajo.dist-query.table-partition.task-volume-mb", 256 * 1024 * 1024),
      

        Activity

        Hide
        mhthanh Mai Hai Thanh added a comment -

        Hi Hyunsik Choi,
        I submitted a patch for this bug. I examined the related code and saw that only a little thing needs to be modified (in the patch).

        Show
        mhthanh Mai Hai Thanh added a comment - Hi Hyunsik Choi , I submitted a patch for this bug. I examined the related code and saw that only a little thing needs to be modified (in the patch).
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12657745/TAJO-952.Mai.140725.patch.txt
        against master revision 72808e0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 211 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/471//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/471//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/471//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/471//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657745/TAJO-952.Mai.140725.patch.txt against master revision 72808e0. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 211 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/471//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/471//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/471//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/471//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        +1
        thanks Mai Hai Thanh!

        Show
        jihoonson Jihoon Son added a comment - +1 thanks Mai Hai Thanh !
        Hide
        jihoonson Jihoon Son added a comment -

        I committed the patch against master branch.
        Thanks!

        Show
        jihoonson Jihoon Son added a comment - I committed the patch against master branch. Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #317 (See https://builds.apache.org/job/Tajo-master-build/317/)
        TAJO-952: Wrong default partition volume config. (Mai Hai Thanh via jihoon) (jihoonson: rev b49ff30b9a3da97d347e8e08798affceac79e6bb)

        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #317 (See https://builds.apache.org/job/Tajo-master-build/317/ ) TAJO-952 : Wrong default partition volume config. (Mai Hai Thanh via jihoon) (jihoonson: rev b49ff30b9a3da97d347e8e08798affceac79e6bb) CHANGES tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java

          People

          • Assignee:
            mhthanh Mai Hai Thanh
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development