Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-949

PullServer does not release files, when a channel throws an internal exception

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Data Shuffle
    • Labels:
      None

      Description

      if channel.close() is not called in exception handler, never closed files in this request. possible file descriptor leaks.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/76

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/76
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #326 (See https://builds.apache.org/job/Tajo-master-build/326/)
        TAJO-949: PullServer does not release files, when a channel throws an internal exception. (jinho) (jinossy: rev 242d6ad656685b82f2c552aa09abe862107ae366)

        • tajo-core/src/main/java/org/apache/tajo/engine/function/math/Round.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java
        • tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #326 (See https://builds.apache.org/job/Tajo-master-build/326/ ) TAJO-949 : PullServer does not release files, when a channel throws an internal exception. (jinho) (jinossy: rev 242d6ad656685b82f2c552aa09abe862107ae366) tajo-core/src/main/java/org/apache/tajo/engine/function/math/Round.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/worker/Fetcher.java tajo-yarn-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-core/src/test/java/org/apache/tajo/worker/TestFetcher.java CHANGES tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
        Hide
        jhkim Jinho Kim added a comment -

        I've committed it

        Show
        jhkim Jinho Kim added a comment - I've committed it
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/76#issuecomment-51163819

        Thank you for the review!!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/76#issuecomment-51163819 Thank you for the review!!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/76#issuecomment-51143689

        @jinossy

        I reviewed your patch again, it ran successfully.
        Push it now.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/76#issuecomment-51143689 @jinossy I reviewed your patch again, it ran successfully. Push it now.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/76#issuecomment-50982469

        @blrunner
        Sorry too late response. I've rebase and refactoring
        Could you review this again ?

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/76#issuecomment-50982469 @blrunner Sorry too late response. I've rebase and refactoring Could you review this again ?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/76#issuecomment-49391925

        +1

        Thank you for your contribution. It looks good overall.
        Push it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/76#issuecomment-49391925 +1 Thank you for your contribution. It looks good overall. Push it.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/76

        TAJO-949: PullServer does not release files, when a channel throws an in...

        ...ternal exception

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-949

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/76.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #76


        commit e3a4e72d2164ae6fc9f8e9e13d5df54adee59868
        Author: jinossy <jinossy@gmail.com>
        Date: 2014-07-15T16:22:03Z

        TAJO-949: PullServer does not release files, when a channel throws an internal exception


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/76 TAJO-949 : PullServer does not release files, when a channel throws an in... ...ternal exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-949 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/76.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #76 commit e3a4e72d2164ae6fc9f8e9e13d5df54adee59868 Author: jinossy <jinossy@gmail.com> Date: 2014-07-15T16:22:03Z TAJO-949 : PullServer does not release files, when a channel throws an internal exception

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development