Uploaded image for project: 'Tajo (Retired)'
  1. Tajo (Retired)
  2. TAJO-940

Default null config for CSV file in StoreTableExec should be moved to planning phase.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Won't Fix
    • None
    • None
    • None
    • None

    Description

      For more clear code, the null config should be moved to the planning phase.

      "StoreTableExec.java"
       if (plan instanceof InsertNode) {
            InsertNode createTableNode = (InsertNode) plan;
            appender = StorageManagerFactory.getStorageManager(context.getConf()).getAppender(meta,
                createTableNode.getTableSchema(), lastFileName);
          } else {
            String nullChar = context.getQueryContext().get(ConfVars.CSVFILE_NULL.varname, ConfVars.CSVFILE_NULL.defaultVal);
            meta.putOption(StorageConstants.CSVFILE_NULL, nullChar);
            appender = StorageManagerFactory.getStorageManager(context.getConf()).getAppender(meta, outSchema,
                lastFileName);
          }
      

      Attachments

        Issue Links

          Activity

            People

              hyunsik Hyunsik Choi
              hyunsik Hyunsik Choi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: